Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature-8986: Missing spacing in some areas like button of calendar a… #9002

Merged
merged 6 commits into from Jul 28, 2023
Merged

feature-8986: Missing spacing in some areas like button of calendar a… #9002

merged 6 commits into from Jul 28, 2023

Conversation

ntthitrinh
Copy link
Contributor

@ntthitrinh ntthitrinh commented Jul 26, 2023 •
edited
Loading

…nd badge preview area

Fixes #8986 #8988

Short description of what this resolves:

Missing spacing in some areas like button of calendar and badge preview area
Event Wizard: Sessions and Speakers page show session colors config in big height

Changes proposed in this pull request:

  • Missing spacing in some areas like button of calendar and badge preview area
  • Event Wizard: Sessions and Speakers page show session colors config in big height

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Jul 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-event-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2023 4:14am

@khangon
Copy link
Contributor

khangon commented Jul 27, 2023 •
edited
Loading

Hi @norbusan , @mariobehling , @cweitat ,
We have completed ticket #8986
This bug has impact code to the Sessions & Speakers page. So causing error like above #8988.
Please help me check and verify tickets 8986 and 8988 on this PR
Thanks,
Screenshot from 2023-07-27 16-19-51

Screenshot from 2023-07-27 16-20-25

Screenshot from 2023-07-27 16-42-55

@ntthitrinh ntthitrinh marked this pull request as ready for review July 27, 2023 09:40
mariobehling
mariobehling requested changes Jul 27, 2023
View reviewed changes
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2023-07-27 16-19-51

Thank you. Please standardize the spacing. Change spacing below "Calendar" button to match the spacing above the button.

@ntthitrinh
Copy link
Contributor Author

ntthitrinh commented Jul 28, 2023 •
edited
Loading

Screenshot from 2023-07-27 16-19-51

Thank you. Please standardize the spacing. Change spacing below "Calendar" button to match the spacing above the button.

Hi @mariobehling,
I fixed it. Please help me check.
Thanks,
image

mariobehling
mariobehling approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mariobehling mariobehling merged commit 6bf7577 into fossasia:development Jul 28, 2023
7 of 8 checks passed
@ghost ghost deleted the ntthitrinh-tma/feature-8986 branch August 2, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariobehling mariobehling mariobehling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing spacing in some areas like button of calendar and badge preview area
3 participants
@ntthitrinh @khangon @mariobehling